Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Munging fails on Integer data type when passed value is an integer or a float #314

Closed
hajee opened this issue May 2, 2023 · 4 comments · Fixed by #317
Closed

Munging fails on Integer data type when passed value is an integer or a float #314

hajee opened this issue May 2, 2023 · 4 comments · Fixed by #317
Labels

Comments

@hajee
Copy link

hajee commented May 2, 2023

Munging fails on Integer data type when passed value is an integer or a float

In Ruby 3.2, the Integer and float data type no longer supports the =~ operator. Causing correct values passed to te munger to fail.

Running the unit tests on Ruby 3.2 shows all these errors. The log is attached to this issue.

Environment

  • Version: When running Puppet 8 on Ruby 3.2
  • Platform All

Additional Context

Add any other context about the problem here.
unit-test.log

@hajee hajee added the bug label May 2, 2023
@hajee
Copy link
Author

hajee commented May 4, 2023

@cthorn42 Is this software still actively maintained by Puppet? It needs some adjusting for use with Puppet 8. Is that planned?

@hajee
Copy link
Author

hajee commented May 24, 2023

I would really appreciate it if somebody told me what the plans are for this gem. I would guess that a lot of custom types that are built using this gem will fail on Ruby 3.2 and thus Puppet8. So I would guess somebody at Perforce/Puppet would have a plan for this?

@cthorn42
Copy link
Collaborator

@hajee I'm sorry I didn't get back to you earlier, I was out of the office when you initially pinged me on this ticket.
I created a ticket in our system, https://tickets.puppetlabs.com/browse/PUP-11866, to track this issue.
I don't have an expected timeline but this issue is now on our radar. Thank you for reporting this.

@jordanbreen28 jordanbreen28 linked a pull request Dec 18, 2023 that will close this issue
@jordanbreen28
Copy link
Contributor

Closed in #317 and released in v1.8.18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants