New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(SERVER-564) Re-enable legacy Puppet status endpoint #531
(SERVER-564) Re-enable legacy Puppet status endpoint #531
Conversation
This commit re-enables the legacy Puppet Ruby status endpoint. It simply whitelists the endpoint in Puppet Server code so that the request can be passed through to Ruby Puppet code.
@@ -54,4 +55,4 @@ | |||
:content-type "text/plain" | |||
:uri "/foo/file_bucket_file/bar"})] | |||
(is (= "application/octet-stream" | |||
(get-in resp [:request :content-type])))))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
~mccuneprinciple !!!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
moar newlines!
🙈 Should we add a simple test for this endpoint as well? |
Via addition to the |
👍 |
@fpringvaldsen - you good with this coming in w/o the additional integration-level test? |
@camlow325 Yup! The test coverage here is sufficient. |
…le-legacy-status-endpoint (SERVER-564) Re-enable legacy Puppet status endpoint
This commit re-enables the legacy Puppet Ruby status endpoint. It
simply whitelists the endpoint in Puppet Server code so that the request
can be passed through to Ruby Puppet code.