Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(SERVER-564) Re-enable legacy Puppet status endpoint #531

Conversation

camlow325
Copy link
Contributor

This commit re-enables the legacy Puppet Ruby status endpoint. It
simply whitelists the endpoint in Puppet Server code so that the request
can be passed through to Ruby Puppet code.

This commit re-enables the legacy Puppet Ruby status endpoint.  It
simply whitelists the endpoint in Puppet Server code so that the request
can be passed through to Ruby Puppet code.
@@ -54,4 +55,4 @@
:content-type "text/plain"
:uri "/foo/file_bucket_file/bar"})]
(is (= "application/octet-stream"
(get-in resp [:request :content-type]))))))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

~mccuneprinciple !!!!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moar newlines!

@MSLilah
Copy link
Contributor

MSLilah commented May 11, 2015

🙈

Should we add a simple test for this endpoint as well?

@camlow325
Copy link
Contributor Author

Via addition to the test_master_routes test, we would have a unit-level test which validates that a request to the endpoint returns a 200 OK / at least matching a route. I could add an integration-level test which also validates the response payload. We've typically shied away from going that far in Puppet Server Clojure tests, though, except for simple smoke tests and cases where we've implemented Puppet Server-level fixes for bugs, like the file_bucket_file binary output. If others think adding the extra test on is compelling, I can do that. Otherwise, though, I'd prefer not to bother with writing a test whose primary value would seem to be about validating core Ruby Puppet functionality.

@jeffmccune
Copy link
Contributor

👍

@camlow325
Copy link
Contributor Author

@fpringvaldsen - you good with this coming in w/o the additional integration-level test?

@MSLilah
Copy link
Contributor

MSLilah commented May 12, 2015

@camlow325 Yup! The test coverage here is sufficient.

MSLilah pushed a commit that referenced this pull request May 12, 2015
…le-legacy-status-endpoint

(SERVER-564) Re-enable legacy Puppet status endpoint
@MSLilah MSLilah merged commit 2928a25 into puppetlabs:stable May 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants