Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(SERVER-652) Changes to acceptance tests to support Windows #545

Conversation

camlow325
Copy link
Contributor

This commit includes some changes to the Puppet 3.x acceptance tests to
support testing in a Windows environment. These include:

  1. Dynamically determine the temp directory to store synced simmons
    module content into.

  2. Replace use of openssl with md5sum for performing md5 sums of files
    on the agent node. md5sum is available on Windows nodes via cygwin.

  3. Unskip external_fact_output_test for Windows since it is viable for
    Windows agents.

@@ -1,4 +1,4 @@
simmons_version = '0.3.1'
simmons_version = '0.3.2'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOTE: This ticket will not be mergeable until dependent changes to the nwolfe-simmons module are merged and published in a new version, 0.3.2, to the Puppet Forge. See nwolfe/puppet-simmons#1.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dangit, I screwed up some stuff with the Forge and module release - @camlow325 could you bump this to 0.3.3 please?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Was a small enough change that I just force-push updated to 0.3.3 in bba0571.

This commit includes some changes to the Puppet 3.x acceptance tests to
support testing in a Windows environment.  These include:

1) Dynamically determine the temp directory to store synced simmons
   module content into.

2) Replace use of openssl with md5sum for performing md5 sums of files
   on the agent node.  md5sum is available on Windows nodes via cygwin.

3) Unskip external_fact_output_test for Windows since it is viable for
   Windows agents.
@camlow325 camlow325 force-pushed the maint/2.1.x/SERVER-652-puppet-3.x-comp-tests-in-windows branch from 768b07a to bba0571 Compare May 19, 2015 19:57
@nwolfe
Copy link
Contributor

nwolfe commented May 19, 2015

👍

nwolfe added a commit that referenced this pull request May 19, 2015
…3.x-comp-tests-in-windows

(SERVER-652) Changes to acceptance tests to support Windows
@nwolfe nwolfe merged commit 1f17b1e into puppetlabs:2.1.x May 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants