(#17522) Only print load errors to debug with non-specific context #1454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a variable assignment that landed in the wrong branch during a conflict merge (a4451fb). Commit a8575f4 fixed a spec failure but the original code wasn't restored. This restores the original functionality in #14136 where a non-specific context (i.e. /files/etc) would be optimised (only load lenses for files under /etc) but since it was vague, would only log load errors to debug. Instead, load errors were reported as warnings for non-specific contexts. Load errors will continue to be reported as warnings for supplied contexts if they're specific.
|
See 911e2d4 for the original code for #14136. |
|
Thank you for contributing to Puppet! Merged into master as cc267a8. This should be released in puppet 3.2. Thanks again for the contribution! -Jeff |
|
Err, that should have been "puppet 3.2" and not 3.3 in my previous comment. I've edited it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces GH-1280, rebased to master.
Fixes a variable assignment that landed in the wrong branch during a conflict
merge (a4451fb). Commit a8575f4 fixed a spec failure but the original code
wasn't restored.
This restores the original functionality in #14136 where a non-specific
context (i.e. /files/etc) would be optimised (only load lenses for files under
/etc) but since it was vague, would only log load errors to debug. Instead,
load errors were reported as warnings for non-specific contexts.
Load errors will continue to be reported as warnings for supplied contexts if
they're specific.