Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary fix for Puppet 3.0 #98

Closed
wants to merge 1 commit into from
Closed

Conversation

igreg
Copy link

@igreg igreg commented Oct 10, 2012

Fixes errors like "Iptables provider cannot handle attribute X"

It defines the methods when the methods when the class is loaded by ruby and avoid relying on method missing which is not supported by Puppet.

Most parameters are covered although a few ones like 'tcp_flags' have been excluded because they weren't supported by all providers.

Fixes errors like "Iptables provider cannot handle attribute X"

It defines the methods when the methods when the class is loaded by ruby and avoid relying on method missing which is not supported by Puppet.

Most parameters are covered although a few ones like 'tcp_flags' have been excluded because they weren't supported by all providers.
@hakamadare
Copy link

This patch appears to address the issue under Puppet 2.7.20 as well.

@carlhopf
Copy link

can confirm this

@gilbertc777
Copy link

I actually took the code (manually typed since I am on disconnected
network) from the pending github patch, applied it, and this has resolved
my issue on puppet 3.0.1

On Mon, Nov 26, 2012 at 4:02 PM, mrlocus notifications@github.com wrote:

can confirm this, would be nice to get this pulled in


Reply to this email directly or view it on GitHubhttps://github.com//pull/98#issuecomment-10733702.

@powertoaster
Copy link

Manual patch resolved it for me too. puppet 3.0.1

@dcarley
Copy link
Contributor

dcarley commented Jan 14, 2013

I'm wondering if mk_resource_methods is appropriate.

However I can't seem to reproduce the error myself. Can anyone provide more details and manifest code?

@igreg
Copy link
Author

igreg commented Jan 14, 2013

I can't remember how I ran into this error sorry.
I tried to reproduce it with puppet 3.0.0, 3.0.1 and 3.0.2 without luck.
I'll keep it commented out in my codebase and see from there if it comes back.

On a separate note, I generally discourage the use of Object#method_missing that increases significantly the code complexity but that's just my personal opinion.

@dcarley
Copy link
Contributor

dcarley commented Jan 14, 2013

Cheers @igreg

The upstream change to 3.0 and 2.7.20 was:

@shockinghobby
Copy link

Applying this patch fixes the issue on 3.0.2.

@kbarber kbarber closed this Feb 23, 2013
@ruckc ruckc mentioned this pull request Feb 25, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants