-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update camptocamp-kmod to puppet-kmod #538
Comments
@sazzle2611 could you provide a PR that updates the name? https://github.com/puppetlabs/puppetlabs-kubernetes/blob/main/metadata.json#L32-L33 and https://github.com/puppetlabs/puppetlabs-kubernetes/blob/main/.fixtures.yml#L9 |
Would it be a good idea to update the dependencies version also?
|
Should I update the puppet-archive dependency to < 6.0.0 or < 7.0.0 as v6.0.0 drops support for Ubuntu 16.4. It is EoL but it is supported by this module |
Sorry just realised that it doesn't matter as previous versions can still be used |
I've created PR #539 This is the first one I've ever done so hopefully I've done it right!! |
@sazzle2611 Hope you are doing well. Thank you for your pull and merge request. Probably this could be closed now? |
@bitvijays yes, thank you very much! |
This module has been taken over so puppet now complains about missing dependency since we needed to change the module in order to upgrade it as it was dependency for another module.
The text was updated successfully, but these errors were encountered: