Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove need to pass root_password twice #283

Closed
jburnham opened this issue Sep 25, 2013 · 2 comments
Closed

remove need to pass root_password twice #283

jburnham opened this issue Sep 25, 2013 · 2 comments

Comments

@jburnham
Copy link

in order for the root_password to be set in the /root/.my.cnf and also manage it with mysql_user, you have to pass root_password to mysql_server and also add root_password to the override_options hash. Why not merge in the root_password parameter into the options hash as a third hash, something like:

$root_pw_hash = { root_password => $root_password }
$options = mysql_deepmerge($mysql::params::default_options, $override_options, $root_pw_hash)

This way in mysql::server::root_password template it can continue to lookup the root_password from the options hash. You would also change the if statement to be like

if $mysql::server::options['root_password'] != 'UNSET' {
@jburnham
Copy link
Author

I can do this as a PR once you merge in #282

@jburnham
Copy link
Author

fixed in #288

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant