(MODULES-3740) Adding missing undocumented rabbitmq tcp_listen_options directive #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mixacha
changed the title
Slm0n87
pushed a commit
to Slm0n87/puppet-rabbitmq
that referenced
this pull request
Mar 7, 2019
(MODULES-3740) Adding missing undocumented rabbitmq tcp_listen_options directive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've noticed changes in our RabbitMQ infrastructure after upgrading Puppet module to the latest forge release, tcp_listen_options were added to RabbitMQ configuration template. Unfortunately, one option was missing and it changes significantly on how broker terminates connections after heartbeat has expired - instead of previous behaviour of sending RST,ACK it starts sending FIN,ACKs instead causing libraries that don't have good exception handling or they aren't using publisher confirms options for publishing messages to start losing messages.
Adding this directive as per https://github.com/rabbitmq/rabbitmq-server/blob/master/src/rabbit.app.src as it's listed as default but not documented on RabbitMQ website.