revision => 'v1.3.4' is executed on every puppet run

[igalic]

I'm running into idempotency problems with the following code change to puppet-gitlab

We have revision => '1.7.9' (which is a tag), with ensure => 'present', yet it's being executed on every puppet run:

igalic@git01 ~ % sudo puppet agent -t 
[sudo] password for igalic: 
Info: Retrieving plugin
Info: Loading facts in /var/lib/puppet/lib/facter/facter_dot_d.rb
Info: Loading facts in /var/lib/puppet/lib/facter/pe_version.rb
Info: Loading facts in /var/lib/puppet/lib/facter/concat_basedir.rb
Info: Loading facts in /var/lib/puppet/lib/facter/has_group_libvirtd.rb
Info: Loading facts in /var/lib/puppet/lib/facter/puppet_vardir.rb
Info: Loading facts in /var/lib/puppet/lib/facter/root_home.rb
Info: Loading facts in /var/lib/puppet/lib/facter/has_libvirtd.rb
Info: Caching catalog for git01.esat
Info: Applying configuration version '1386881409'
Notice: /Stage[main]/Gitlab::Package/Vcsrepo[/home/git/gitlab-shell]/revision: revision changed '9e00fb4078ca8a168687f876c1f6a98198a68155' to 'v1.7.9'
Notice: Finished catalog run in 10.65 seconds
sudo puppet agent -t  7,51s user 2,16s system 45% cpu 21,312 total
2 igalic@git01 ~ % sudo puppet agent -t 
Info: Retrieving plugin
Info: Loading facts in /var/lib/puppet/lib/facter/facter_dot_d.rb
Info: Loading facts in /var/lib/puppet/lib/facter/pe_version.rb
Info: Loading facts in /var/lib/puppet/lib/facter/concat_basedir.rb
Info: Loading facts in /var/lib/puppet/lib/facter/has_group_libvirtd.rb
Info: Loading facts in /var/lib/puppet/lib/facter/puppet_vardir.rb
Info: Loading facts in /var/lib/puppet/lib/facter/root_home.rb
Info: Loading facts in /var/lib/puppet/lib/facter/has_libvirtd.rb
Info: Caching catalog for git01.esat
Info: Applying configuration version '1386881409'
Notice: /Stage[main]/Gitlab::Package/Vcsrepo[/home/git/gitlab-shell]/revision: revision changed '9e00fb4078ca8a168687f876c1f6a98198a68155' to 'v1.7.9'
Notice: Finished catalog run in 8.95 seconds
sudo puppet agent -t  7,13s user 2,06s system 61% cpu 14,987 total
2 igalic@git01 ~ % 

[luisfdez]

I'm also affected by this issue :(

[jvoorhis]

👍

This makes vcsrepo practically unusable in situations where I want to refresh resources only when the content of the repo changes.

[chelnak]

Hello! We are doing some house keeping and noticed that this issue has been open for a long time.

We're going to close it but please do raise another issue if the issue still persists. 😄