Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom ConfigService #312

Open
DeLaGuardo opened this issue Apr 15, 2024 · 0 comments
Open

Allow custom ConfigService #312

DeLaGuardo opened this issue Apr 15, 2024 · 0 comments

Comments

@DeLaGuardo
Copy link
Contributor

Use Case

There are some libraries that makes configuration much easier, e.g. aero. But specifically aero configuration might contain tagged literals unrecognized by clojure.edn/read. And because the same configuration files is used for both (logging and application configuration) it is not enough to simply introduce custom implementation of ConfigService in the bootstrap.cfg file.

Describe the Solution You Would Like

  1. Separate logging configuration from the main config (e.g. encapsulate it in the new tk-config.edn to highlight that this config is for the framework itself)
  2. Do not inject ConfigService when such service already present in services list.

Describe Alternatives You've Considered

Create separate LogginService with a single dependency: ConfigService. For correct logging initialization this might require altering services startup order to always load ConfigService and then LoggingService before other application services.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant