Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ppm:category filter: "ALL" should be default and combobox CATEGORY items shouldn't be hard-coded. #1766

Closed
s243a opened this issue Feb 29, 2020 · 0 comments

Comments

@s243a
Copy link
Contributor

s243a commented Feb 29, 2020

So I was slightly stumped about why on arch32pup no items showed up in the ppm when I selected the repo arch-32-core (See post). The reason turned out to be that there were no items assigned the catagory (Desktop)...at least as processed by 0setup.

Personally, I don't think that the packages should be filtered by Category unless the user deliberately decides to filter them. I personally, wouldn't expect something to be filtered by default and as a consequence I was confused by the output.

We can atually make "ALL" the default category by adding one line of code. Simply insert

<item>ALL</item>

above:
/rootfs-skeleton/usr/local/petget/pkg_chooser.sh#L544

We can do this because the function filterpkgs.sh is looking for this category:

#120813 there may be optional subcategory, put ; into pattern...
categoryPATTERN="|${fltrCATEGORY}[;|]"
[ "$fltrCATEGORY" = "ALL" ] && categoryPATTERN="|" #let everything through.

/rootfs-skeleton/usr/local/petget/filterpkgs.sh#L85
Perhaps puppy once had the option in the "package chooser" to select "ALL" as the category.

Anyway, what I suggest is that we create a variable in /var/PKGS_MANAGEMENT that lists the categories that we want to show up in the package chooser. This var could be populate via a function that reads the data from an external file like /usr/local/petget/categories.dat.

I'll do a pull/merge request for consideration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants