Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jQuery.fn.v_toggleVolume() should be jQuery.fn.v_toggle_volume() #26

Open
alessandro-newzoo opened this issue Sep 26, 2019 · 0 comments

Comments

@alessandro-newzoo
Copy link

Hi,

Based on the docs, the method jQuery.fn.v_toggleVolume() should toggle the mute status, but if I use that the console will say that .v_toggleVolume is not a function

So I took a look at the source files and turns out we should use jQuery.fn.v_toggle_volume instead, which in fact works fine.

Not working example (based on the Docs):

	$('.icon-unmute').click(function() {
		$('#P1').v_toggleVolume();
	});

Working example (not in the Docs, based on source files inspection):

	$('.icon-unmute').click(function() {
		$('#P1').v_toggle_volume();
	});

So long story short, please fix the docs :)

Thanks a lot!

@alessandro-newzoo alessandro-newzoo changed the title jQuery.fn.v_toggleVolume() should be jQuery.fn.v_toggle_volume jQuery.fn.v_toggleVolume() should be jQuery.fn.v_toggle_volume() Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant