Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requires package-lint 0.2? #11

Open
progfolio opened this issue May 7, 2023 · 4 comments
Open

requires package-lint 0.2? #11

progfolio opened this issue May 7, 2023 · 4 comments

Comments

@progfolio
Copy link

progfolio commented May 7, 2023

;; Package-Requires: ((emacs "24.1") (flycheck "0.22") (package-lint "0.2"))

Is there a package-lint 0.2?
It looks like package-lint declares a Version of "0":

https://github.com/purcell/package-lint/blob/8f7c46d204c9ebe99e3843934be726fa3a3e5190/package-lint.el#L9

For some context as to why I'm asking:

straight.el and Elpaca have been asked to issue warnings when a package requires a higher version of a dependency than that which is installed. While developing the feature, flycheck-package requesting package-lint 0.2 is the only package which was flagged (on my personal init).

@purcell
Copy link
Owner

purcell commented May 8, 2023

Yes, you can see the package here: https://stable.melpa.org/#/package-lint (0.17, in fact!)

The MELPA Stable build machinery fills in the headers using the tag. It would be invalid for straight/elpaca to assume that the headers in the files in a git repository would always be correct: many repos use placeholder versions like this and rely on the packaging process to fill them in.

@progfolio
Copy link
Author

many repos use placeholder versions like this and rely on the packaging process to fill them in.

Do we have any numbers on this?
I think it's actually a pretty rare case.
Most package I encounter maintain the Version metadata in the source file despite a *-pkg.el file being generated by an ELPA's build system.

https://github.com/search?q=%22%3B%3B+Version%3A%22++language%3Aelisp+NOT+is%3Afork&type=code&p=5

@purcell
Copy link
Owner

purcell commented May 8, 2023

No, I don't have stats, but I have about 57 of 'em just directly under my user account here, several quite popular, so that's "many", and I've seen it elsewhere too. I know there's a push by the GNU folks to use ;; Version headers in the source code, but it means constant bumping of that for each release, and it has consequences for dev versions and branching schemes. How would straight or elpaca even find stable releases in git repos? It seems those tools would need to be told to use tags, or look in certain branches anyway.

@progfolio
Copy link
Author

How would straight or elpaca even find stable releases in git repos? It seems those tools would need to be told to use tags, or look in certain branches anyway.

That's not the goal of the feature. The goal is to warn users when a package declares a dependency version greater than the version the user has installed. For more context:

radian-software/straight.el#1083

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants