Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

visual glitch when used with native line numbers in emacs master #16

Closed
CSRaghunandan opened this issue Jul 10, 2017 · 5 comments
Closed

Comments

@CSRaghunandan
Copy link

I recently compiled emacs master build which contains the native line numbers implemented by Eli Zaretski. I gave it a shot and found a visual glitch with page-break-lines-mode. Please refer to the screenshot below:

screen shot 2017-07-11 at 12 49 12 am

@purcell
Copy link
Owner

purcell commented Jul 10, 2017

Thanks. I guess that window-width still reports the full window width with this mode, whereas with linum-mode is just reports the usable width. Should be something I can patch, but before I investigate that might I suggest you ask on the list whether this difference is expected?

@CSRaghunandan
Copy link
Author

CSRaghunandan commented Jul 11, 2017

Maybe you can use line-number-display-width which will return the width of the line number window and subtract it with window-width - 1 ?

@purcell
Copy link
Owner

purcell commented Jul 12, 2017

Maybe. I don't currently have a HEAD version of Emacs available, and don't have time to dig into this just yet, so if you want to propose a change that works for you and will still work with older Emacs versions, I'd be happy to integrate it.

@CSRaghunandan
Copy link
Author

I do not use line numbers myself and presently, I do not have the time to contribute a patch. Maybe someone else more capable will fix the issue :) I'm a noob with elisp

@kaushalmodi
Copy link

@CSRaghunandan It might be best to file a bug report about this. You don't have to provide a patch. Just list the steps starting with emacs -Q..

  1. Start emacs -Q.
  2. Clone this repo: https://github.com/purcell/page-break-lines
  3. Load this package, enable line numbers, etc. to get to the visual bug you are seeing. and also reference this thread in that bug report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants