Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible incorrect selector #153

Closed
Perturbatio opened this issue Jul 30, 2013 · 5 comments
Closed

Possible incorrect selector #153

Perturbatio opened this issue Jul 30, 2013 · 5 comments

Comments

@Perturbatio
Copy link

The comma at the end of the opera selector on line 12 in grids-core https://github.com/yui/pure/blob/master/src/grids/css/grids-core.css#L12
(and also in grids-r) makes all grids have negative word spacing, this is causing problems for me in chrome

@bradleyfalzon
Copy link

I'll let the authors chime in as well, but if it helps, all .pure-g elements (which have a negative word-spacing) contain the various .pure-u-* elements (which override the word-space with normal).

So I think your issue might just be you're not nesting .pure-u-* elements inside the .pure-g elements.

Eg

<div class="pure-g-r">
    <p>Warped word spacing</p>
    <div class="pure-u-1-2"><p>Normal word spacing - Column 1</p></div>
    <div class="pure-u-1-2"><p>Normal word spacing - Column 2</p></div>
</div>

@Perturbatio
Copy link
Author

The markup is correct, this is a chrome specific issue where the units shift left further than they should.

<div id="footer-social-links" class="yui3-g-r">
    <div class="yui3-u">
        <a class="cta cta-facebook" href="#">Facebook</a>
    </div>
    <div class="yui3-u">
        <a class="cta cta-twitter" href="#">Twitter</a>
    </div>
    <div class="yui3-u">
        <a class="cta cta-linkdin" href="#">LinkdIn</a>
    </div>
</div>

@ericf
Copy link
Collaborator

ericf commented Jul 30, 2013

@Perturbatio this is an Opera-only hack that other browsers read and stop parsing at: :-o-prefocus and ignore the rest of that selector declaration. If you look in the Inspector, you'll see that the word-spacing is not being applied to your grid container.

Could you provide more info and an example page which shows your issue? Also which OS are you seeing this on?

@Perturbatio
Copy link
Author

I think I've discovered a why it was occurring, I was using grids from http://yui.github.io/gridbuilder/ (using the yui3 prefix if you can't tell from my previous comment) it has word-spacing for yui3-g-r and the opera-only hack in the generated CSS

@ericf
Copy link
Collaborator

ericf commented Jul 31, 2013

Okay, can you file an issue with Gridbuilder then? Thanks for catching this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants