Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offsets should be UTF-16 code units #96

Open
puremourning opened this issue Jan 27, 2020 · 1 comment
Open

Offsets should be UTF-16 code units #96

puremourning opened this issue Jan 27, 2020 · 1 comment
Labels
bug Something isn't working Severity 3+ The issue is rare or cosmetic, or unfixable
Projects

Comments

@puremourning
Copy link
Owner

Describe the bug

The DAP uses utf-16 code units for offsets (ref: microsoft/debug-adapter-protocol#91).

Vimspector uses probably a mix of byte offsets and unicode codepoints.

To Reproduce

Add a line with a multi-byte character and a language (like TCL) that provides the column offset.

Expected behavior

Offsets are interpreted correctly according to the appropriate notion of "characters"

Actual behaviour

Not sure yet, i haven't tried it, but i expect tracebacks

@puremourning puremourning added bug Something isn't working Severity 3+ The issue is rare or cosmetic, or unfixable labels May 15, 2020
@puremourning puremourning added this to Needs triage in Fix issues via automation May 15, 2020
@puremourning puremourning moved this from Needs triage to Low priority in Fix issues Feb 23, 2021
@puremourning
Copy link
Owner Author

This has been clarified in microsoft/debug-adapter-protocol#285; the result is the same, it's UTF16 code units. Shrug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Severity 3+ The issue is rare or cosmetic, or unfixable
Projects
Fix issues
  
Low priority
Development

No branches or pull requests

1 participant