Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onBeforeInput event #31

Closed
MonaMayrhofer opened this issue Sep 5, 2023 · 1 comment · Fixed by #32
Closed

onBeforeInput event #31

MonaMayrhofer opened this issue Sep 5, 2023 · 1 comment · Fixed by #32

Comments

@MonaMayrhofer
Copy link
Contributor

There does not seem to be any mention of the beforeinput event within this package.

Is there a reason for this?

And if no, where would that event find it's place? From a quick look over this package it seems like GlobalEvents would be a good candidate - because then it's colocated with onInput, however i am not sure of all the implications of putting it there...

type GlobalEvents r =
( onContextMenu :: Event
, onInput :: Event
| r
)

Thanks a lot!

@garyb
Copy link
Member

garyb commented Sep 5, 2023

I think it makes sense add it there - some of the organization of these may not be 100% accurate, but it's kinda harmless with events since they just won't be triggered. I think onInput is here because it can apply to any element thanks to contenteditable, so the same logic would apply to onBeforeInput.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants