Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid query strings cause exceptions #43

Open
bklaric opened this issue Sep 3, 2017 · 2 comments
Open

Invalid query strings cause exceptions #43

bklaric opened this issue Sep 3, 2017 · 2 comments

Comments

@bklaric
Copy link
Contributor

bklaric commented Sep 3, 2017

Hyper uses decodeURIComponent to parse query string. However, decodeURIComponent has an incorrect type as documented here, since it throws an exception on invalid input.

I'm unsure whether it would be better to wait for the related issue to be resolved or to use something else for decoding strings.

@owickstrom
Copy link
Collaborator

Yeah, maybe we should switch over to https://pursuit.purescript.org/packages/purescript-uri/4.0.0/docs/Data.URI.Query. I just skimmed it, but it seems to be the corresponding thing, but with a safe parser and type.

@bklaric
Copy link
Contributor Author

bklaric commented Sep 4, 2017

Thanks, I'll look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants