-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test reporter hangs on async tests #1
Comments
Thanks for reporting! I'll look into this as soon as possible. :) |
OK, I know what's the issue here and it's the implementation of the Mocha reporter together with how reporters work in purescript-spec. Working on it now. :) |
any news on this? i may have time to contribute code to this, and changes will improve if you can fill us in on what you already know. thanks! (-: |
Oh, sorry for dropping the ball on this one. Have been short on time lately, but I got somewhere with this on the It does not compile but I think it's nearly there. The idea is to change from having a fully collected test result tree which the reporters can use, to let reporters await tests themselves. -- Previously:
type Reporter e = Array Group -> Eff e Unit
-- Now:
type Reporter e = Array (Group (Aff e Unit)) -> Aff e Unit This way the mocha reporter can call the underlying If you have the time to look at this and perhaps finish the stuff that I started that would be very helpful! :) I'd love to get some more people involved in this project. By the way, this could be affected by purescript-spec/purescript-spec#16, the suggestion for a Free monad implementation of purescript-spec to support selective runs of test (skip, only). |
ok, thanks! i should be able to work with that. now it's my turn to drop the ball. but i'll try not to! give me a week or two- (-: |
No problem at all, I guess it's you folks that need this the most right now, and I'm just utterly grateful for all the help I can get. 👍 |
A year later, and now this works. I got some energy for my PureScript projects and decided to fix this limitation. Use |
When I use the mocha test reporter to run a test like the following
, the test page just hangs showing
passes: 0 failures: 0 duration: 0s
. If I comment out the line containinglater'
, everything works and the test success is shown. In either case the second log message is shown in the console.(I apologise if this is expected behaviour / a user error. I'm new to purescript and js programming in general.)
The text was updated successfully, but these errors were encountered: