Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check node version manually on startup #9

Open
hdgarrood opened this issue Jun 17, 2019 · 0 comments
Open

Check node version manually on startup #9

hdgarrood opened this issue Jun 17, 2019 · 0 comments

Comments

@hdgarrood
Copy link
Collaborator

The purescript npm package currently has an engines constraint of >= 10.16.0, but this does not appear to be sufficient to stop people getting confused when the installer fails on older node versions, see e.g. purescript/purescript#3677. I think this is because npm only warns on an unsatisfied engines constraint by default rather than erroring.

We can make these failures easier to understand (and also not reliant on details of the particular npm client in use) by checking for them manually in this package and generating the appropriate errors ourselves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant