Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suggestions #2

Closed
jdegoes opened this issue Mar 10, 2015 · 3 comments
Closed

suggestions #2

jdegoes opened this issue Mar 10, 2015 · 3 comments

Comments

@jdegoes
Copy link

jdegoes commented Mar 10, 2015

I was going to create this. :)

Can I suggest changing the name of the class to IFunctor, and the name of the map function to imap? The other name people use for this is XFunctor, xmap, etc., but personally I prefer IFunctor / imap.

@garyb
Copy link
Member

garyb commented Mar 10, 2015

Good call on the imap yep, and I should probably have mentioned something along the lines of "also known as an exponential functor" in the docs.

As for IFunctor, I can see why, as Invariant is a bit vague perhaps, but should we be reconsidering the name of Contravariant as well then?

@jdegoes
Copy link
Author

jdegoes commented Mar 10, 2015

I'd prefer Contravariant be ContraFunctor or some such. There are an infinitely many things which are invariant and contravariant, and no particular reason why covariant functors should be the only ones to get Functor in the name somewhere.

Just my 2 cents, of course.

@LiamGoodacre
Copy link
Member

Closing as this looks like a stale issue. I don't see much point in renaming now, Data.Functor.Invariant seems appropriate enough. Please reopen otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants