Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package sets (rationals, sequences) #309

Closed
thomashoneyman opened this issue Jul 15, 2023 · 23 comments
Closed

Update package sets (rationals, sequences) #309

thomashoneyman opened this issue Jul 15, 2023 · 23 comments

Comments

@thomashoneyman
Copy link
Member

{
  "packages": {
    "sequences": "3.0.2",
    "rationals": "6.0.0"
  }
}
@pacchettibotti
Copy link
Contributor

Attempting to build package set update.

@pacchettibotti
Copy link
Contributor

The package set produced from this suggested update does not compile.

@thomashoneyman
Copy link
Member Author

Looks like sequences doesn't work, at least, because it depends on a package that no longer exists (was deprecated in 0.14 and removed in 0.15):

Attempting batch of changes...
Uninstalling rationals@5.0.1
Installing package set packages...
Installing rationals@6.0.0
No cache found for rationals-6.0.0 at path scratch/.cache/rationals-6.0.0
Downloading rationals@6.0.0 from https://packages.registry.purescript.org/rationals/6.0.0.tar.gz
Successfully downloaded rationals@6.0.0 into a buffer.
Wrote cache entry for rationals-6.0.0 as a buffer at path scratch/.cache/rationals-6.0.0
Installing sequences@3.0.2
No cache found for sequences-3.0.2 at path scratch/.cache/sequences-3.0.2
Downloading sequences@3.0.2 from https://packages.registry.purescript.org/sequences/3.0.2.tar.gz
Successfully downloaded sequences@3.0.2 into a buffer.
Wrote cache entry for sequences-3.0.2 as a buffer at path scratch/.cache/sequences-3.0.2
Compiling installed packages...
Uninstalling rationals@6.0.0
Uninstalling sequences@3.0.2
Installing package set packages...
Installing rationals@5.0.1
Compilation failed with errors:
Error 1 of 1

  Module: Data.Sequence
  File: packages/sequences@3.0.2/src/Data/Sequence.purs
  Message:

    Module Control.MonadZero was not found.
  Make sure the source file exists, and that it has been provided as an input to the compiler.


  Error details:
  https://github.com/purescript/documentation/blob/master/errors/ModuleNotFound.md

[ERROR] The package set produced from this suggested update does not compile.
Notifying via a GitHub comment on issue 309
[NOTIFY] The package set produced from this suggested update does not compile.
Created GitHub comment on issue 309

@thomashoneyman
Copy link
Member Author

Let's try just rationals...

{
  "packages": {
    "rationals": "6.0.0"
  }
}

@pacchettibotti
Copy link
Contributor

Attempting to build package set update.

@pacchettibotti
Copy link
Contributor

The package set produced from this suggested update does not compile.

@thomashoneyman
Copy link
Member Author

In the second case, rationals causes abc-parsers to break due to the switch to bigints:

Attempting batch of changes...
Uninstalling rationals@5.0.1
Installing package set packages...
Installing rationals@6.0.0
No cache found for rationals-6.0.0 at path scratch/.cache/rationals-6.0.0
Downloading rationals@6.0.0 from https://packages.registry.purescript.org/rationals/6.0.0.tar.gz
Successfully downloaded rationals@6.0.0 into a buffer.
Wrote cache entry for rationals-6.0.0 as a buffer at path scratch/.cache/rationals-6.0.0
Compiling installed packages...
Uninstalling rationals@6.0.0
Installing package set packages...
Installing rationals@5.0.1
Compilation failed with errors:
Error 1 of 1

  Module: Data.Abc.Canonical
  File: packages/abc-parser@2.0.0/src/Data/Abc/Canonical.purs
  Message:

    Could not match type

    BigInt

  with type

    Int


while checking that expression case ((Tuple (numerator r)) (denominator r)) of
                                 (Tuple 1 1) -> ""
                                 (Tuple 1 2) -> "/"
                                 (Tuple n 1) -> show n
                                 (Tuple _ _) -> showRatio r
  has type String
in value declaration duration


  Error details:
  https://github.com/purescript/documentation/blob/master/errors/TypesDoNotUnify.md

[ERROR] The package set produced from this suggested update does not compile.
Notifying via a GitHub comment on issue 309

If we want this to be updated then we will need to notify the author of abc-parser and give them some time to update; if they do not, then we can consider dropping abc-parser from the package sets and updating rationals.

@f-f
Copy link
Member

f-f commented Jul 15, 2023

@newlandsvalley would you be able cut a new release of abc-parser based on the latest release of rationals?

@newlandsvalley
Copy link

Yes, certainly. I may not be able to make a start on it for a couple of days, though.

@newlandsvalley
Copy link

Why don't you drop abc-parser anyway and I'll resubmit it once the new rationals is established?

@f-f
Copy link
Member

f-f commented Jul 15, 2023

Sounds great, thanks!

{
  "packages": {
    "rationals": "6.0.0",
    "abc-parser": null
  }
}

@pacchettibotti
Copy link
Contributor

Attempting to build package set update.

@pacchettibotti
Copy link
Contributor

Built and released a new package set! Now mirroring to the package-sets repo...

@pacchettibotti
Copy link
Contributor

Mirrored a new legacy package set.

@newlandsvalley
Copy link

I've made the change to abc-parser. Where are the latest instructions on how to (re-) publish a package? (I've been absent for a few months....)

@f-f
Copy link
Member

f-f commented Jul 15, 2023

@newlandsvalley thanks! You can just publish a new tag, the package set importer will pick it up tomorrow 🙂

@newlandsvalley
Copy link

Great! Many thanks, @f-f .

@newlandsvalley
Copy link

I notice that the new release of abc-parser (v2.0.1) doesn't exist in recent package-sets releases, although it has been published OK. What do I need to do?

@f-f
Copy link
Member

f-f commented Aug 7, 2023

Something like this:

{
  "packages": {
    "abc-parser": "2.0.1"
  }
}

@pacchettibotti
Copy link
Contributor

Attempting to build package set update.

@pacchettibotti
Copy link
Contributor

Built and released a new package set! Now mirroring to the package-sets repo...

@pacchettibotti
Copy link
Contributor

Mirrored a new legacy package set.

@newlandsvalley
Copy link

That was quick! Very many thanks, @f-f .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants