Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't run in FireMonkey #180

Closed
dtrauma opened this issue Jul 10, 2023 · 4 comments
Closed

Doesn't run in FireMonkey #180

dtrauma opened this issue Jul 10, 2023 · 4 comments

Comments

@dtrauma
Copy link

dtrauma commented Jul 10, 2023

Heya, this extension doesn't run in Firemonkey because of this:

sizzlemctwizzle/GM_config#113

Detailed explanation here:

https://github.com/sizzlemctwizzle/GM_config/wiki/Asynchronous-read-and-write-migration

This also (subtly) affects Greasemonkey 4 users.

@Purfview
Copy link
Owner

Purfview commented Jul 10, 2023

The script doesn't use that GM_config version. What issue do you have?

@Purfview Purfview changed the title Firemonkey (and GM4): get before init is complete Doesn't run in FireMonkey Jul 10, 2023
@Purfview
Copy link
Owner

This also (subtly) affects Greasemonkey 4 users.

What is that subtle affect?

@Purfview
Copy link
Owner

Purfview commented Jul 10, 2023

To make it work in FireMonkey:
Go to FireMonkey options > select the script > in Options press "Wrap code in IIFE" > press Save

PS:
Noticed some bug changing imdb's icon to some icons from the script.

@dtrauma
Copy link
Author

dtrauma commented Jul 12, 2023

Indeed, this works, thank you. And sorry if my report was misleading, I was guided by the error message and only now realized that I didn't include it in the report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants