Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow --highlight_words true with --sentence #228

Closed
niksedk opened this issue Mar 31, 2024 · 6 comments
Closed

Allow --highlight_words true with --sentence #228

niksedk opened this issue Mar 31, 2024 · 6 comments

Comments

@niksedk
Copy link

niksedk commented Mar 31, 2024

Could it be possible to allow --highlight_words true with parameters like --sentence or --standard?

The highlight is a nice feature, but a bit difficult to use in a subtitle with the current long blocks.

@Purfview
Copy link
Owner

Not with the current "--sentence" implementation, solution could be to enable the wonky original Whisper's max chars breaking, or to implement alternative code to do something similar like "sentence".

@niksedk
Copy link
Author

niksedk commented Mar 31, 2024

OK

@niksedk niksedk closed this as completed Mar 31, 2024
@Purfview
Copy link
Owner

Allowed and implemented in r189.1 -> #229

@ghost
Copy link

ghost commented Apr 1, 2024

@Purfview so can I use highlight_words and sentence at the same time?

@Purfview
Copy link
Owner

Purfview commented Apr 1, 2024

@Purfview so can I use highlight_words and sentence at the same time?

Yes, but --sentence isn't doing anything for highlight_words.

Only --max_line_width and --max_line_count does stuff for it out of all max thresholds. And there are some internal splitting heuristics.

niksedk added a commit to SubtitleEdit/subtitleedit that referenced this issue Apr 1, 2024
@niksedk
Copy link
Author

niksedk commented Apr 1, 2024

Allowed and implemented in r189.1 -> #229

Awesome, works very well :)

SE beta updated: https://github.com/SubtitleEdit/subtitleedit/releases/download/4.0.4/SubtitleEditBeta.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants