Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Converted into Clean Code #255

Closed
wants to merge 2 commits into from
Closed

Converted into Clean Code #255

wants to merge 2 commits into from

Conversation

vedant-jain03
Copy link
Contributor

Related Issuse

Closes: #218

Describe the changes you've made

  • Converted Master Branch Homepage.js (Line:301) into CleanCode(Line:160)
  • Converted Master Branch Homepage.css (Line:516) into CleanCode(Line:279)
  • I just want to re-edit Contributor Section in next issue because It was aligned according to left,right top and in clean code it should be converted into flex only.
  • I have not mentioned contributor in this code because it was aligned upper rather then lower in js file.
  • I also want to change the contributor section design as it was not looking good with theme and In dark mode.

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.(Specially for Backend)
  • My changes generate no new warnings.

@codewithvk
Copy link
Collaborator

@vedant-jain03 Resolve conflict !

@vedant-jain03
Copy link
Contributor Author

@codewithvk I have been assign issue #252 where I have to write whole code from Scratch
Their is just one conflict in this files that I have not added Contributor section and I have also mentioned in Description why I do it so.
Otherwise their is no conflict as it is totally working fine in my system.

@purnima143 purnima143 closed this Apr 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@purnima143 purnima143 Awaiting requested review from purnima143

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

converting home page js and css into clean code
3 participants
@vedant-jain03 @codewithvk @purnima143