Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend: Build Product card Component for both light and dark modes #47

Closed
Lovelyfin00 opened this issue May 27, 2023 · 3 comments
Closed
Labels
gssoc23 level2 Enhancement of existing features

Comments

@Lovelyfin00
Copy link
Collaborator

Lovelyfin00 commented May 27, 2023

Issue Summary

The design for Product card as part of the Product component has been completed and now it needs to be built using our chosen tech stacks. The Product card has to be inside the Product component story

Figma link

The design for the Product card can be found here. Please make sure what you build follows the design.

Suggested fix

  • Build the Product card component following the design in the Figma file.
  • Make sure your codes are maintainable and legible.
  • After coding the component using React and scss, create storybook for the component.
  • Test it out on your end and make sure it's working properly.

Coding Rules

  • Let your codes look neat and readable
  • No unnecessary spacing and always leave one empty line after each code block
  • Separate each word with a hyphen - in your scss classes, ids.

PR Rules

  • Link the issue your PR is for by saying Fixes #PRNumber
  • Add a description of what your PR is about
  • Add screenshots or video of the working implementation of your PR

Preview

Light mode



Dark mode


@Lovelyfin00 Lovelyfin00 added gssoc23 level2 Enhancement of existing features labels May 27, 2023
@shivam-jainn
Copy link
Contributor

I am working on this !

@bhoomikhurana
Copy link

Has this work been done yet?I would like to take up this issue and apply my skills into it

@Lovelyfin00
Copy link
Collaborator Author

Yes. Someone is working on it

@Lovelyfin00 Lovelyfin00 changed the title Frontend: Build Products Component Frontend: Build Product card Component Jun 8, 2023
@Lovelyfin00 Lovelyfin00 changed the title Frontend: Build Product card Component Frontend: Build Product card Component for both light and dark modes Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc23 level2 Enhancement of existing features
Projects
None yet
Development

No branches or pull requests

3 participants