Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not try to unsubscribe uninitialized machines #97

Closed
scollier opened this issue Jul 7, 2015 · 2 comments
Closed

Do not try to unsubscribe uninitialized machines #97

scollier opened this issue Jul 7, 2015 · 2 comments

Comments

@scollier
Copy link
Contributor

scollier commented Jul 7, 2015

When running a vdestroy, omv tries to unsubscribe machines that have never been initialized. Perhaps omv should check the status of the machine before trying to unsubscribe it. To reproduce the issue:

Example:

$ vs
Current machine states:

master1                   running (libvirt)
master2                   running (libvirt)
master3                   running (libvirt)
node1                     not created (libvirt)


$ vdestroy node1
Running 'subscription-manager unregister' on: node1...
==> node1: Domain is not created. Please run `vagrant up` first.
==> node1: Remove stale volume...
==> node1: Domain is not created. Please run `vagrant up` first.
@scollier scollier changed the title Do not try to unscribe uninitialized machines Do not try to unsubscribe uninitialized machines Jul 7, 2015
@purpleidea
Copy link
Owner

@scollier vagrant (and omv) runs the command you ask it to. We can actually detect in omv which command vagrant is running eg: https://github.com/purpleidea/oh-my-vagrant/blob/master/vagrant/Vagrantfile#L552 but at the moment, without recursively calling vagrant status (a bad idea) I don't know how to get the status of a particular machine during a vagrant run.

If this is possible, LMK and we can patch OMV. Until this, it's not.
So I'll leave this open for a week if you want to ask around... Maybe on the mitchellh/vagrant project?

@purpleidea
Copy link
Owner

No updates. Please open a new issue upstream or here if you still have this problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants