Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature : 'OnChange' event handler does not transmit parameter (like select value) #180

Closed
snichele opened this issue Mar 21, 2023 · 1 comment
Assignees
Labels
bug Something isn't working workaround

Comments

@snichele
Copy link

I have a select box, like for example :

select(onChange(...), option(value:="one"), ...)

but the 'onChange' handler does not transmit me the selected option value (at least, not in the current API)...

Endend up doing something like this, which is not pretty :

select(
      onEvent("change", (e: Tyrian.Event) =>
        val selectValue = e.target.asInstanceOf[HTMLSelectElement].value;
        // ...
      )
    // ...
)

Maybe I'm missing something (not so) obvious ? :)

@davesmith00000
Copy link
Member

PR with the fix is done, I shall merge it in the morning after I've looked it over with fresh eyes. 😄

#181

@davesmith00000 davesmith00000 self-assigned this Mar 21, 2023
@davesmith00000 davesmith00000 added bug Something isn't working workaround labels Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working workaround
Projects
None yet
Development

No branches or pull requests

2 participants