Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release libmimalloc-sys changes in 3a845029? #84

Closed
nc7s opened this issue Sep 24, 2022 · 6 comments
Closed

Release libmimalloc-sys changes in 3a845029? #84

nc7s opened this issue Sep 24, 2022 · 6 comments

Comments

@nc7s
Copy link

nc7s commented Sep 24, 2022

3a84502 changed quite a few enum values, I wonder why that wasn't released.

I'm packaging the mimalloc and libmimalloc-sys crates on Debian, patching -sys to use already packaged libmimalloc-dev 2.0.6. It failed extended::tests::runtime_option_page_reset as it used an old enum value.

@thomcc
Copy link
Contributor

thomcc commented Sep 24, 2022

We definitely shouldn't be adding tests for the experimental enum values -- arguably they shouldn't be exposed at all.

(I should keep a closer eye on this repo...)

@nc7s
Copy link
Author

nc7s commented Sep 24, 2022

Without this happening, I'll happily package it and it'll silently fail later...

@thomcc
Copy link
Contributor

thomcc commented Sep 24, 2022

People shouldn't use the experimental constants if they aren't using a fixed/pinned version of mimalloc.

@nc7s
Copy link
Author

nc7s commented Sep 24, 2022

There's only one version of libmimalloc-dev in one Debian dist (unstable/testing/etc.) at a time, so, yeah, basically pinned. We used it instead of the bundled mimalloc.

@thomcc
Copy link
Contributor

thomcc commented Sep 24, 2022

No, that's not really pinned. I mostly mean statically linked against the bundled version. E.g. Debian might update mimalloc without rebuilding the code using it (which is the issue here).

I wonder if we should put these (and any other incomplete API that can't safely be used by code which dynamically links mimalloc) behind some kind of experimental feature that people need to explicitly enable. Then, Debian should just not package a version with such a feature enabled.

@nc7s
Copy link
Author

nc7s commented Sep 24, 2022

If you mean reverse deps aren't updated along with mimalloc itself, that's a problem, but not a big one - maintainers will handle that.

Currently I have marked the extended.rs tests flaky. Or experimental features could be patched out?

@nc7s nc7s closed this as completed Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants