Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tippyjs from MenuBar and Action Center #69

Closed
PuruVJ opened this issue Apr 16, 2021 · 2 comments · Fixed by #73
Closed

Remove tippyjs from MenuBar and Action Center #69

PuruVJ opened this issue Apr 16, 2021 · 2 comments · Fixed by #73
Assignees
Labels
enhancement New feature or request

Comments

@PuruVJ
Copy link
Owner

PuruVJ commented Apr 16, 2021

Currently, MenuBar, to show menus, uses TippyJS and lots of state management with Jotai. But that is quite slow.

Goal:
Remove TippyJS from the equation entirely.
Rely on CSS as much as possible, though using Jotai to show stuff actually seems like the best scenario here, as :hover will not work unidirectionally, that is, it will show as well as hide on hover and removed-hover, which we do not want.

Same goes for ActionCenter. Use same methods for it too

@Aslemammad
Copy link
Collaborator

I'm going to work on this issue, thanks.

@PuruVJ PuruVJ added the enhancement New feature or request label Apr 16, 2021
@PuruVJ
Copy link
Owner Author

PuruVJ commented Apr 16, 2021

The files to look at: MenuBar.tsx and Menu.tsx, both in TopBar folder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants