Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

every "custom language" seem use "displayAppName" that only can set by once time #51

Closed
bau720123 opened this issue Nov 23, 2014 · 2 comments

Comments

@bau720123
Copy link

these are all my code

function checkAppRate(action, action2)
{
AppRate.preferences.useLanguage = action
AppRate.preferences.displayAppName = action2;
AppRate.preferences.storeAppURL.ios = '864908959';
AppRate.preferences.storeAppURL.android = 'market://details?id=com.littlebau.phonegap';
AppRate.promptForRating(true);
}

<li onClick="checkAppRate('zh-TW','soft1');">botton1</li>
<li onClick="checkAppRate('zh-Hans','soft2');">botton2</li>
<li onClick="checkAppRate('zh-TW','soft3');">botton3</li>

ween I use botton1,it will show the 'zh-TW' dialog and the dialog's displayAppName become 'soft1',good~
ween I use botton2,it will show the 'zh-Hans' dialog and the dialog's displayAppName become 'soft2',good~

but...
ween I use botton3,it will show the 'zh-TW' dialog and the dialog's displayAppName still 'soft1'

so I just want to ask..
if every "custom language" seem use "displayAppName" that only can set by once time at the same moment

@bau720123 bau720123 changed the title every "custom language" seem use "displayAppName" that only set by once time every "custom language" seem use "displayAppName" that only can set by once time Nov 23, 2014
@pushandplay
Copy link
Owner

@bau720123 you can improve translation here https://crowdin.net/project/apprate-cordovaphonegap-plugin or update a source code and make a pull request.

@bau720123
Copy link
Author

hi @pushandplay
you misunderstood what I mean
this is not businesss by translation
this is my code (for example android)

function checkAppRate(action, action2, action3)
{
AppRate.preferences.useLanguage = action
AppRate.preferences.displayAppName = action2;
AppRate.preferences.storeAppURL.android = 'market://details?id=' + action3;
AppRate.promptForRating(true);
}

<li onClick="checkAppRate('zh-TW','soft1','com.littlebau.phonegap');">botton1</li>
<li onClick="checkAppRate('zh-TW','soft2','com.facebook.katana');">botton2</li>

if you press botton1 first,it will show the 'sof1' displayAppName,and finally connect to the google play (com.littlebau.phonegap)
and...now
change press botton2,but it will still show the 'sof1' displayAppName (it should be 'soft2',because I set to 'soft2'),and finally connect to the google play (com.facebook.katana)

I just want to know,why "storeAppURL.android" can According to the parameters and then guided to the right position I want to go

but...displayAppName can't
[[it seem like same useLanguage's code that the displayAppName only set once time only]]

I must be know why first that I can make a pull request...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants