Support the PreferEmailToUser option on PassUserHeaders #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordancrawfordnz
requested review from
JoelSpeed,
steakunderscore and
loshz
as code owners
Previously in #401, an option was added to support forwarding the email address as the username to the upstream service when the PassBasicAuth option is used. The PassBasicAuth option is not appropriate for all users, with PassUserHeaders allowing very similar functionality without specifying a basic auth headers. The PreferEmailToUser option has been expanded to support the PassUserHeaders option.
JoelSpeed
approved these changes
Mar 8, 2020
|
Awesome thanks @JoelSpeed! Any idea when the next release will be tagged? Just keen to get our applications off a manual build I did and back onto an official version. |
|
We've been trying to do every 3 months or so, so I'd expect it to be some time in April unless we find some time to do so sooner |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously in #401, an option was added to support forwarding the email
address as the username to the upstream service when the PassBasicAuth
option is used.
The PassBasicAuth option is not appropriate for all users, with PassUserHeaders
allowing very similar functionality without specifying a basic auth headers.
The PreferEmailToUser option has been expanded to support the PassUserHeaders
option.
Motivation and Context
For the application I run, I use the PassUserHeaders option but since upgrading to 5.0.0 the username header has been providing the user ID, as discussed in #369.
Now, with this change, I can consistently authenticate based on email address.
How Has This Been Tested?
Unit tests have been added for this scenario and I've deployed a build with this change to my server using this new option and confirmed it works successfully.
Checklist: