New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blitz can't clear caches for urls containing ü,ö,ë etc #252
Comments
$expiryDate
not set
$expiryDate
not set
Have you set the What versions of Blitz and Craft are you running? |
@bencroker yes... false, that's most likely the culprit. Changed that and now it works. |
Glad to hear it! |
Reopening. Though the elements are now in shown in the blitz_elementcaches table, they are still not cleared properly. What i mentoined "worked" was a small workaround we made. Any idea? |
Blitz 3.6.8 and craft 3.5.8 |
How exactly are you testing and what is not working? |
|
Here is how I would suggest testing:
|
@bencroker We're not working with a folder, cache is stored in a redis db. |
Ok, are there any other things in your setup that deviate from the defaults? |
|
Btw, cloudflare is not enabled at the moment. We also worked on the clearRelatedCaches if you can remember, but that doesn't interfere with the refreshCache functionality |
I see you're using |
@bencroker no problems on local with the normal file storage, staging also uses the YiiCacheStorage adaptor as an interface for the cache-stores. |
So if the issue is limited to your production environment then it sounds like it might be a devops issue. If you can't solve it then I'd be happy to schedule some time to help troubleshoot this with you via email or chat. |
@bencroker just found out it works for some entries, and others not. As fas as I can see, entries with special characters int he url like ü are failing to clear, others work. |
@bencroker and only when using the redis store, when using the regular text files they don't give issues. |
Just tested a couple of extra posts, all posts with a ä, ü etc in the url have this issue, none of the others. |
That's very possibly the cause of the issue. Perhaps you can look into whether this is something you can solve in your redis store. |
@bencroker turns out its not only redis, also file storage adaptor has this issue as well This is the url When Blitz creates the cache, the following files are created: But when deleting, it tries to delete web/cache/blitz/early-games.test/de/dota-2-braucht-die-replay-takeover-funktion-zurueck-dringend/index.html (without omlaut, but the umlaut is actually stored in the path resulting in Blitz being unable to delete the file) Looks like a bug in Blitz, just can't pinpoint where its going wrong. Can you take a look? |
Am not seeing this but will run some tests. Reference: #222 |
Fixed for the file storage driver in 4305794, can you test if this solves the issue on your end? |
Hi @bencroker, |
That's next on the list ;) |
Hi @bencroker, |
This was introduced as a fix to the issue when using the file storage driver.
This has to be fixed for the Yii cache storage driver and then it will be released. |
Hi @bencroker, How is it going with the YiiCache Storage adaptor? |
@lenvanessen My tests are passing using the YiiCacheStorage driver d708dcc Can you please test again using 5cef138 which may have resolved it? |
Released in version 3.6.9. |
Thanks mate, sorry i didn't have the time to test |
@bencroker: I just updated to 3.6.10 (not having installed 3.6.9 before) and I still get 2 directories in the cache dir, when the directory name contains a special char. I understood this was just a workaround, or is this going to stay like this? I can confirm, that pages in both directories get deleted when the corresponding entry is modified. I can also confirm, that cache warming seems to create the files in both directories. |
This is the fix as it seems that depending on how the server is configured, it will look for the cached file in one of those two directories. |
We have a strange issue with Blitz at the moment.
Caches or being generated and served by blitz, and our blitz_caches table counts 4600 rows. However, our blitz_elementcaches counts 0. So whenever the RefreshCacheJob tries to locate the cacheIds it thinks there aren't any.
So the RefreshCacheJob can't find the cacheIds for the page, and the page remains unchanged.
Any idea why this might be happening?
The text was updated successfully, but these errors were encountered: