New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cache not clearing after saving Commerce products #474
Comments
Are you saying that the product page is not cleared, or an element that is related to a product? Please provide more details so I can replicate locally. |
Thanks for quick repsonse. The product I am editing is not cleared. The product field is just one type of edit I am doing on the product. Another is the text field in step 3. |
Ok, can you please rephrase it to the simplest example which is not working as expected, with steps to replicate? |
|
Thank you, I'll investigate that use-case today. |
I believe this is due to products not auto-saving drafts, which I've fixed in 3473b56 for the next release. |
On second look, this method looks like it's too eager – fields are always marked as dirty when saved in the CP, regardless of whether they have changed or not. I'll need to look into whether something has changed in recent Craft versions and otherwise come up with a workaround. |
I can confirm blitz does not seem to clear cache on normal entries too:
We have this problem on two separate sites now after updating Blitz to latest. Edit: We use "Clear the cache and regenerate in a queue job" as refresh mode. |
@Mathias-Syversen did you update Craft as well as Blitz? Just trying to figure out which update might have caused this change in behaviour. |
@Mathias-Syversen I just ran a local test and modifying an entry does refresh the cache as expected. Can you please create a new issue with more details so as to not confuse the issue we're working through here with Commerce products? |
It looks like elements that do not support drafts, which includes Commerce products, were not triggering cache refreshes as of version 4.3.0. I've fixed in 3473b56 and released in version 4.3.1. It would be great if you could confirm that this fixes your issue @philipboomy. |
@bencroker I can confirm it is fixed. Cache is clearing after saving a product. |
I am running into products not refreshing after clicking save.
I waited till queue was done running just in case. Didn't change anything.
Logging is on locally but nothing in the log.
Blitz 4.3.0 and Craft CMS 4.3.8.1
The text was updated successfully, but these errors were encountered: