Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation message #524

Closed
wants to merge 1 commit into from

Conversation

mattstein
Copy link
Contributor

A person with dusty old templates calling craft.blitz.getUri() will encounter this deprecation message in the control panel:

Screen Shot 2023-06-28 at 12 32 55 PM@2x

And if this misguided adventurer does indeed replace it with craft.blitz.fetch() and bother testing it, he’ll discover no such method exists.

The docblock is already correct, and this PR fixes the deprecation warning to recommend craft.blitz.fetchUri() instead.

@sonarcloud
Copy link

sonarcloud bot commented Jun 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bencroker
Copy link
Collaborator

Thanks for the PR, but this has already been addressed in 1e81e11. I probably should have put it into a minor release, but honestly wasn’t expecting 4.5.0 to take this long. Getting there, though!

@bencroker bencroker closed this Jun 28, 2023
@mattstein mattstein deleted the patch-1 branch June 28, 2023 20:34
@bencroker
Copy link
Collaborator

Released in version 4.4.7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants