Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cached includes don't regenerate when using the includedQueryStringParams setting #573

Closed
JodebaDigitalPulse opened this issue Oct 24, 2023 · 5 comments
Labels
bug Something isn't working

Comments

@JodebaDigitalPulse
Copy link

Steps to reproduce the issue.

  1. Set some allowed query parameters in includedQueryStringParams
  2. Refresh expired cached includes

A clear and concise description of what you expected to happen.

The updated file is found in _includes/index.html instead of _includes/action=blitz%2Finclude%2Fcached&index=123

I had to include action and index to includedQueryStringParams to fix it.

The plugin and Craft version numbers.

Craft CMS 4.5.7 with Blitz 4.6.0

@JodebaDigitalPulse JodebaDigitalPulse added the bug Something isn't working label Oct 24, 2023
@bencroker
Copy link
Collaborator

Can you please explain the second step, specifically how you refresh expired cached includes?

@JodebaDigitalPulse
Copy link
Author

Hi Ben, I'm using the method Expire the cache and regenerate in a queue job and run the command php craft blitz/cache/refresh-expired

@bencroker
Copy link
Collaborator

I’ve fixed this issue in eb47a0c for the next release.

You can test this by running composer require "putyourlightson/craft-blitz:dev-develop as 4.6.1".

@JodebaDigitalPulse
Copy link
Author

Thanks a lot!

@bencroker
Copy link
Collaborator

Released in 4.7.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants