Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple sites (languages) and disabling entries from another site doesn't clear cache. #631

Closed
Gnative opened this issue Mar 7, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@Gnative
Copy link

Gnative commented Mar 7, 2024

Bug Report

I'm finding an issue where entries are not being cleared from cache or remote deployments in multiple site (language) structures.

I tested this in a clean installation of Craft and Blitz Cache and set up sites for EN (english) and DE (German)

When I create an entry this automatically creates the entries for the other languages and associated cache files when saved.

Screenshot 2024-03-07 at 12 50 58

If I then open the EN entry and decide to disable the DE entry, from with in the EN entry, this does not clear the cache for that DE entry as would be expected.

Screenshot 2024-03-07 at 12 51 10

The same same problem exists for enabling a DE entry, that was previously disabled, from with in an EN entry. The entries cache file is not created.

Plugin Version

4.12.2

Craft CMS Version

4.8.1

PHP Version

8.2.0

@Gnative Gnative added the bug Something isn't working label Mar 7, 2024
@Gnative
Copy link
Author

Gnative commented Mar 7, 2024

Found that with a remote deployment set up this can leave "ghost" pages in the repo that are not cleared if the entry has been disabled when regenerating and redeploying the cache from the Blitz Utility panel.

Think the only way to fix this would be to first manually clear out all file in the repo and then regenerate and redeploy.

@bencroker
Copy link
Collaborator

Thanks for reporting this! Propagating elements were being excluded from the refresh cache process. I’ve changed that behaviour in the bugfix/refresh-propagating-elements branch.

Please test this by running composer require "putyourlightson/craft-blitz:dev-bugfix/refresh-propagating-elements as 4.12.3".

@Gnative
Copy link
Author

Gnative commented Mar 11, 2024

Hi @bencroker thanks for looking at this.. yes it looks to be working in my testing.

@bencroker
Copy link
Collaborator

Great, thanks for testing! Changed in 23ab0b9 and released in 4.13.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants