Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contacts and mailing lists issue in multisite #153

Closed
JeanLucEsser opened this issue Jul 1, 2020 · 6 comments
Closed

Contacts and mailing lists issue in multisite #153

JeanLucEsser opened this issue Jul 1, 2020 · 6 comments
Labels
bug Something isn't working

Comments

@JeanLucEsser
Copy link

Describe the bug

Multisite mailing lists breaks contacts list and contacts import.

When listing contacts and connected with a site specific user, only the mailing list type from the primary site is listed as a filter. When importing contacts, no matter the user, only mailing lists from the primary site can be selected.

To reproduce

Create two sites, Site A (primary) and Site B.
Create FirstUser as admin (all sites) and SecondUser (Site B only).

Let's say you have 2 mailing lists types, one for Site A and one for Site B and one mailing list for each type.

Expected behaviour

When connecting with FirstUser and navigating to contacts, you should be able to use Craft's site dropdown to switch mailing lists type filter depending on which is for which site. That works. When connecting with SecondUser, you should be able to do the same but Craft's site dropdown does not behave as expected and you're stuck with the mailing list types of the primary site and this one only.

When navigating to contacts and go to the import tab (or export or sync), it doesn't matter which user you're connected with, Craft's site dropdown does not work at all. When trying to select a mailing list for import (or export or sync), you can't see any other lists than the one from the primary site.

Versions

  • Plugin version: Latest
  • Craft version: 3.5 beta 3

Note

I think it would be great if you handled contacts in multi site the same way you are with campaigns, mailing lists, segments and sendouts. I'm currently using multisite as a way to deal with user specific campaigns and contacts (for a new client) but I'd argue that's not the best way of doing it. Would be nice to be able to have CRUD permissions on campaigns, contacts and mailing lists on a per user basis. I'll try to spend a few days imagining what that could be like and report back as an enhancement proposition. Maybe you are already working on this topic.

@JeanLucEsser JeanLucEsser added the bug Something isn't working label Jul 1, 2020
@bencroker
Copy link
Collaborator

bencroker commented Jul 3, 2020

Thanks for the detailed report. Can you please clarify the point below? To the best of my knowledge users are not site-specific.

Create FirstUser as admin (all sites) and SecondUser (Site B only).

@JeanLucEsser
Copy link
Author

JeanLucEsser commented Jul 3, 2020

@bencroker sure, it looks like you can assign users to sites so that the user can only access and edit elements from that site. See attached screen capture below. That's what I meant here (I didn't mean that users are site specific per se).

Capture d’écran 2020-07-03 à 12 47 11

I can share more captures to try and illustrate the full issue should you need them.

@bencroker
Copy link
Collaborator

That would be helpful if you could...

@JeanLucEsser
Copy link
Author

Sure! Sorry for the delay.

So let's start by creating SiteA (primary) and SiteB.

Capture d’écran 2020-07-03 à 13 24 48

Then we assign Second User to SiteB (First User being admin).

Capture d’écran 2020-07-03 à 13 26 47

Next we define two mailing lists types, one for each site.

Capture d’écran 2020-07-03 à 13 32 20

After creating one mailing list for each type and subscribing some contacts to them, the issues start arising.

When connected as First User (admin), navigating the contacts for each site seems to work as expected:
Switching from Site A to Site B shows the relevant mailing lists and we can always see all contacts.

Capture d’écran 2020-07-03 à 13 52 25

Capture d’écran 2020-07-03 à 13 52 45

But then it falls apart:

Switching sites from any other tab (import / export / sync) is broken (should it even be possible?).

Capture d’écran 2020-07-03 à 13 54 27

And accessing the mailing lists modal from either tab (import / export / sync) shows only the mailing lists types from the primary site preventing access to the mailing list from SiteB. Although we can create a new mailing list for SiteB from the modal!

Capture d’écran 2020-07-03 à 13 54 56

--

When connecting with Second User, we get stuck with the primary site (SiteA although user permissions are set to edit SiteB only), not only on import / export / sync, but also on the first tab of contacts (view).

Does it help?

@bencroker
Copy link
Collaborator

Yes, thanks for the screenshots and explanations, will look into the issues and see what we can do.

@bencroker
Copy link
Collaborator

Fixed and released in version 1.16.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants