Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Couldn't save general settings #155

Closed
shornuk opened this issue Jul 14, 2020 · 9 comments
Closed

Couldn't save general settings #155

shornuk opened this issue Jul 14, 2020 · 9 comments
Labels
bug Something isn't working

Comments

@shornuk
Copy link

shornuk commented Jul 14, 2020

Installed to test it out. Went to switch to test mode and get "general settings could not be saved" error message. No fields highlighting as errors. Not sure where to test from here?

This was on a local and hosted dev environment.

Versions

  • Plugin version: 1.15.4
  • Craft version: 3.4.27
@shornuk shornuk added the bug Something isn't working label Jul 14, 2020
@bencroker
Copy link
Collaborator

Are you able to successfully save the general settings with test mode disabled? Are all required fields populated?

@shornuk
Copy link
Author

shornuk commented Jul 19, 2020

Hi @bencroker

No, it still gives the error when test mode is disabled. All fields are filled out, the only required field on general settings is the API right?

@shornuk
Copy link
Author

shornuk commented Jul 19, 2020

Just been testing this further. It appears that an issue was caused in the Email Settings pane. The sender name and email were set to environment variables. When I hardcode them, it saves. General setting save too.

@bencroker
Copy link
Collaborator

Great, glad to hear it!

@shornuk
Copy link
Author

shornuk commented Jul 20, 2020

Just to clarify on this, should you be able to use environment variables within the From Names and Emails field?

@bencroker
Copy link
Collaborator

No, only fields that display the This can be set to an environment variable. message can use environment variables.

@shornuk
Copy link
Author

shornuk commented Jul 20, 2020

OK. I think that's where I got confused. The placeholder that was in there looked exactly like an environment variable, and in other places when an environment variable is set, the This can be set to an environment variable message is not shown (the API field in general setting for example). Perhaps it's worth changing so as to not mix them up?

Another small UX suggestion. I'm guessing GeoIP and reCAPTCHA are optional? Feels a bit odd to have a required field asterisk. Just a small niggle, but thought you might like the feedback. Still working though the setup now, but getting there 👍

@bencroker
Copy link
Collaborator

There is no placeholder in the email settings:

Screenshot 2020-07-20 at 17 15 07

The placeholder that was in there looked exactly like an environment variable, and in other places when an environment variable is set, the This can be set to an environment variable message is not shown (the API field in general setting for example). Perhaps it's worth changing so as to not mix them up?

The message is only shown if the field is not already populated with an environment variable. This is a native Craft UI decision, not Campaign.

Screenshot 2020-07-20 at 17 22 24

Another small UX suggestion. I'm guessing GeoIP and reCAPTCHA are optional? Feels a bit odd to have a required field asterisk. Just a small niggle, but thought you might like the feedback. Still working though the setup now, but getting there 👍

Thanks, fixed in 42ad11d.

@shornuk
Copy link
Author

shornuk commented Jul 20, 2020

Thanks, fixed in 42ad11d.

Great!

There is no placeholder in the email settings:

How strange. I had $SYSTEM_EMAIL_ADDRESS & $SYSTEM_EMAIL_NAME pre-populated in there after installing. 🤷‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants