Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sendout status not changed even if its progress is 100% #170

Closed
Saboteur777 opened this issue Sep 9, 2020 · 13 comments
Closed

Sendout status not changed even if its progress is 100% #170

Saboteur777 opened this issue Sep 9, 2020 · 13 comments
Labels
bug Something isn't working

Comments

@Saboteur777
Copy link
Contributor

Question

A sendout seems to be finished, as its progress reached 100%, but its status is "Queued". Is that intentional? Fails count is 517, maxSendFailsAllowed is 500, I have just increased it to 1000.

@Saboteur777 Saboteur777 added the question Further information is requested label Sep 9, 2020
@bencroker
Copy link
Collaborator

What version of the plugin and Craft are you on? 517 failed attempts seems quite excessive, have you checked the campaign.log file to see if there are any clues as to what might be causing it to fail?

@Saboteur777
Copy link
Contributor Author

Saboteur777 commented Sep 9, 2020

It is below 10%, but it is quite high, yes. (This is an imported userbase, with no e-mail validation on the old site, so I expected this.)

I did: I have found some invalid addresses there, but a lot of valid e-mail, like r************@gmail.com (redacted for privacy reasons, but first segment looked fine, too).

edit: I checked the failing e-mail addresses, some of them contained typos, fixed them. I removed all non-existent e-mail addresses (checked with an e-mail validator service), but the sendout is still Queued.

Plugin version: 1.15.6
Craft: 3.5.8

@bencroker
Copy link
Collaborator

Good to hear you cleaned up the list. Failed attempts at valid email addresses are most likely being caused by your email service provider rejecting them.

To run the queue jobs, run this command:
./craft queue/run

@Saboteur777
Copy link
Contributor Author

Saboteur777 commented Sep 9, 2020

Queue is run every minute and I don't see any stuck jobs. Running craft campaign/sendouts/run-pending-sendouts responds with 0 pending sendout(s) queued., but the sendout is still stuck on Queued status.

kepernyokep_20200909_140327

@bencroker
Copy link
Collaborator

Can you pause the sendout and then restart it?

@Saboteur777
Copy link
Contributor Author

That did the trick, thanks!

@Saboteur777
Copy link
Contributor Author

Sorry for reopening this: the issue is still here.
If the sendout experiences fails, then the sendout is getting executed repeatedly via a cronjob, thus inflating the fail count and never succeed.

In details: the sendout is almost complete (it is at 100%), but there were fails during the sending process. A recent example: the sendout has 1765 recipient, fail count is 4, expected recipients is 4 after the first tick. When the cronjob triggers the sendout, it is queued up again, finishes fast and the fail count is now 8, the recipients count is still 4. And this happens again and again, until the sendout is cancelled.

@bencroker
Copy link
Collaborator

Ok thanks, I'll look into whether this might be a bug.

@bencroker bencroker reopened this Oct 14, 2020
@bencroker bencroker added bug Something isn't working and removed question Further information is requested labels Oct 14, 2020
@Saboteur777
Copy link
Contributor Author

Thanks! Let me know if you need anything for this from me.

@bencroker
Copy link
Collaborator

Fixed in 375f506 for the next release.

@bencroker
Copy link
Collaborator

Released in 1.17.0.

@Saboteur777
Copy link
Contributor Author

Thank you Ben - we evaluated this in the last weeks and it is definitely solved! 🥳

@bencroker
Copy link
Collaborator

Glad to hear it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants