Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

German translation #296

Merged
merged 2 commits into from Feb 26, 2022

Conversation

andreasbecker
Copy link
Contributor

Translated all the phrases into German except for the plugin name which stays "Campaign"

@sonarcloud
Copy link

sonarcloud bot commented Feb 23, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bencroker
Copy link
Collaborator

bencroker commented Feb 23, 2022

Thank you Andreas!! Will take a closer look and then merge this in.

@bencroker bencroker merged commit 976167e into putyourlightson:develop Feb 26, 2022
@bencroker
Copy link
Collaborator

I changed "Abbestellen" to "Abmelden" for consistency, in e7dbb41.

Do you think it would make sense to translate "complained" and "bounced"?
Screenshot 2022-02-26 at 12 43 53

@andreasbecker
Copy link
Contributor Author

No, as far as I know there is no appropriate translation for "bounced" and "complained" in this context. You could say "rückgesendet" and "moniert" respectively, but it sounds a little weird and I've never heard that concerning the email status.

I also haven't translated "blocked". But that could actually be translated as "blockiert". You could change this.

@bencroker
Copy link
Collaborator

Makes sense, thanks! I made some additional tweaks so that the data tables will be translated too.

Screenshot 2022-02-26 at 19 50 46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants