Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide clickable links in default verification template #303

Closed
iparr opened this issue Mar 16, 2022 · 3 comments
Closed

Provide clickable links in default verification template #303

iparr opened this issue Mar 16, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@iparr
Copy link

iparr commented Mar 16, 2022

The verification link in the default template is not provided as a clickable link.

In many email clients, they will transform this to a link for you. But for some (not sure which ones), they will not.

The following code is available in the raw email:

Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Thank you for subscribing to the mailing list. Please verify your email address by clicking on the following link:
https://domain.com/actions/campaign/forms/verify-subscribe?pid=XXX

Content-Type: text/html; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Thank you for subscribing to the mailing list. Please verify your email address by clicking on the following link:
https://domain.com/actions/campaign/forms/verify-subscribe?pid=XXX

Would it be possible for the text/html portion to instead read (without having to create a custom template):

Thank you for subscribing to the mailing list. Please verify your email address by clicking on the following link:
<a href="https://domain.com/actions/campaign/forms/verify-subscribe?pid=XXX">https://domain.com/actions/campaign/forms/verify-subscribe?pid=XXX</a>

This would guarantee a clickable link in all clients (I think!)

I think this could be addressed here, but I'm not sure how to separate the HTML/plaintext versions: https://github.com/putyourlightson/craft-campaign/blob/develop/src/services/FormsService.php#L91

@iparr iparr added the enhancement New feature or request label Mar 16, 2022
@bencroker
Copy link
Collaborator

I've yet to come across an email client that does not transform URLs into clickable links. Can you provide any specific examples?

@bencroker
Copy link
Collaborator

Never mind, I just added in bb8ae1e for the 2.0.0 release.

@bencroker
Copy link
Collaborator

This has been released in version 2.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants