Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable "edit" action on sendouts not modfiyable #328

Closed
kringkaste opened this issue Sep 16, 2022 · 5 comments
Closed

Disable "edit" action on sendouts not modfiyable #328

kringkaste opened this issue Sep 16, 2022 · 5 comments
Labels
bug Something isn't working

Comments

@kringkaste
Copy link
Contributor

I know this is an edge case, but it would be nice if there was a similar HTML trigger for the edit action as there is for cancel action in sendouts. Because the slideout for edit gets a redirect with 302 from the prepareEditScreen function but as ajax request it doesn't work and you get an empty slideout and a server failure :)

@kringkaste kringkaste added the bug Something isn't working label Sep 16, 2022
@bencroker
Copy link
Collaborator

I'm not quite following, can you please explain in simpler terms?

@kringkaste
Copy link
Contributor Author

Sorry :(

Craft 4.2.4: If you go to sendouts and click on the title of a sendout already send, everything works fine. You get a 302 redirect to the preview URL. If you select the checkbox of the sendout and click on the "edit" action, the edit panel is opening and will be empty and you get a "server failure" flash notice. So it would be better to disable the edit action if you select a sendout not modifiable. Like you do it for the cancel action.

@bencroker
Copy link
Collaborator

Yes, you're absolutely right, thanks for reporting this!!

@bencroker
Copy link
Collaborator

Fixed in 2d713a8 for the next release.

@bencroker
Copy link
Collaborator

Released in version 2.1.7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants