Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verification link error - impossible to join mailing list from website #338

Closed
iparr opened this issue Oct 27, 2022 · 2 comments
Closed
Labels
bug Something isn't working

Comments

@iparr
Copy link

iparr commented Oct 27, 2022

(Two bug reports in one day, sorry but it's just a bad day!)

When users sign-up from an on-website form they are sent an email (this is the default one, I've not changed the template).

This includes a link and upon following that link they get an error.

This is:
Typed property putyourlightson\campaign\models\PendingContactModel::$mailingListId must not be accessed before initialization

This has been working fine as far as I'm aware and has just started the problem with version 2.1.14 (plus Craft 4.3.0). I am using PHP 8.1.

It was reported by a visitor, but I've been able to reproduce exactly the same error upon signing up myself.

Line 189 in in /vendor/putyourlightson/craft-campaign/src/controllers/FormsController.php:
$mailingList = Campaign::$plugin->mailingLists->getMailingListById($pendingContact->mailingListId);

@iparr iparr added the bug Something isn't working label Oct 27, 2022
@bencroker
Copy link
Collaborator

This is caused by a breaking change in Yii 2.0.46 and was fixed in Campaign 2.1.14, however it appears one property was missed! Fixed in 1b7240a and released in 2.1.15.

@iparr
Copy link
Author

iparr commented Oct 27, 2022

Can confirm that this fixes my scenario. Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants