Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sprig Core icons #2

Merged
merged 22 commits into from Oct 11, 2021
Merged

Add Sprig Core icons #2

merged 22 commits into from Oct 11, 2021

Conversation

khalwat
Copy link
Contributor

@khalwat khalwat commented Oct 7, 2021

Four icon variations for you to choose from, all playing on the concept of "Sprig Core" as represented by a seed that has the curly tip of the sprig to tie it together with the original Sprig icon

khalwat and others added 22 commits October 6, 2021 23:58
Signed-off-by: Andrew Welch <andrew@nystudio107.com>
Signed-off-by: Andrew Welch <andrew@nystudio107.com>
Signed-off-by: Andrew Welch <andrew@nystudio107.com>
Signed-off-by: Andrew Welch <andrew@nystudio107.com>
Signed-off-by: Andrew Welch <andrew@nystudio107.com>
Signed-off-by: Andrew Welch <andrew@nystudio107.com>
Signed-off-by: Andrew Welch <andrew@nystudio107.com>
Signed-off-by: Andrew Welch <andrew@nystudio107.com>
Signed-off-by: Andrew Welch <andrew@nystudio107.com>
Signed-off-by: Andrew Welch <andrew@nystudio107.com>
Untested...

Signed-off-by: Andrew Welch <andrew@nystudio107.com>
Signed-off-by: Andrew Welch <andrew@nystudio107.com>
Signed-off-by: Andrew Welch <andrew@nystudio107.com>
Signed-off-by: Andrew Welch <andrew@nystudio107.com>
Signed-off-by: Andrew Welch <andrew@nystudio107.com>
Signed-off-by: Andrew Welch <andrew@nystudio107.com>
Signed-off-by: Andrew Welch <andrew@nystudio107.com>
Signed-off-by: Andrew Welch <andrew@nystudio107.com>
…the attributes

Signed-off-by: Andrew Welch <andrew@nystudio107.com>
Signed-off-by: Andrew Welch <andrew@nystudio107.com>
@bencroker
Copy link
Contributor

bencroker commented Oct 11, 2021

Thanks for the icons and the much more performant implementation of HTML parsing!!

I ended up implementing this with slightly different code but the same idea. For a very large component, the parse time has gone from 3s to 0.007s (without requiring the s-verbatim tag). For an average component, the parse time has not changed and remains at 0.007s. But the fact that the parse time is not affected by the data size is ideal. I'm also happy to be able to remove the dependency on HTML5DOMDocument.

@bencroker bencroker closed this Oct 11, 2021
@bencroker bencroker reopened this Oct 11, 2021
@bencroker bencroker merged commit 37c1195 into putyourlightson:develop Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants