Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't enable emojis #55

Open
alebianco opened this issue Mar 6, 2019 · 1 comment
Open

Can't enable emojis #55

alebianco opened this issue Mar 6, 2019 · 1 comment

Comments

@alebianco
Copy link

Emojis cannot be enabled from the configuration file, the default configuration always takes precedence when the package is initialised.

const config = _.merge(commitizen.configLoader.load(), {
'cz-conventional-commit': {maxSubjectLength: 72, bodyLineLength: 100, emoji: false},
})['cz-conventional-commit'];

@ronnieacs
Copy link

The default config should not have emoji field set on false, that's always disabling emojis in the merge. Should be:

 const config = _.merge(commitizen.configLoader.load(), { 
 	'cz-conventional-commit': {maxSubjectLength: 72, bodyLineLength: 100}, 
 })['cz-conventional-commit']; 

A fixed version is available on: https://github.com/ronnieacs/cz-conventional-commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants