Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_psm3 with tmy will not ignore interval #1702

Closed
mikofski opened this issue Mar 22, 2023 · 1 comment · Fixed by #1712
Closed

get_psm3 with tmy will not ignore interval #1702

mikofski opened this issue Mar 22, 2023 · 1 comment · Fixed by #1712

Comments

@mikofski
Copy link
Member

Describe the bug
docs say if names='tmy' then interval is ignored, but the nrel api raises an HTTPError

To Reproduce
Steps to reproduce the behavior:

d, m = pvl.iotools.get_psm3(
    latitude=38.8, longitude=-121.2,
    api_key='DEMO_KEY', email='email@example.com',
    names='tmy', interval=5)

Expected behavior
NREL API ignores interval

Screenshots
image

Versions:

  • pvlib.__version__: 1.5.2
  • pandas.__version__: 0.9.4
  • python: 3.8.15

Additional context
I think the documentation should be updated?

@AdamRJensen
Copy link
Member

I can confirm this issue.

The current parameter description reads:

interval (int, {60, 5, 15, 30}) – interval size in minutes, must be 5, 15, 30 or 60. Only used for single-year requests (i.e., it is ignored for tmy/tgy/tdy requests).

Should be updated to something along the lines of:

interval (int, {60, 5, 15, 30}) – interval size in minutes, must be 5, 15, 30 or 60. Must be 60 for typical year requests (e.g., tmy/tgy/tdy).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants