Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Erbs diffuse fraction model has discontinuities at transition points #1755

Closed
adriesse opened this issue May 30, 2023 · 0 comments · Fixed by #1834
Closed

Erbs diffuse fraction model has discontinuities at transition points #1755

adriesse opened this issue May 30, 2023 · 0 comments · Fixed by #1834
Milestone

Comments

@adriesse
Copy link
Member

Is your feature request related to a problem? Please describe.
If you look closely at the piecewise definition of the Erbs diffuse fraction model you will see that it is discontinuous at the two transition points. This is not usually a problem, but when the Erbs model happens to be used in some kind of numerical optimization the discontinuities could cause problems.

Describe the solution you'd like
Add a new diffuse fraction function with a piecewise definition that closely matches the original Erbs model but is continuous. And while we're at it we can make the first derivative continuous too.

Describe alternatives you've considered
Modify the existing model function.

Additional context
This has been implemented and tested off line but I don't have the bandwidth for a PR currently. I thought I should mention it since it is somewhat relevant to #1753.

@adriesse adriesse changed the title Erbs diffuse fraction model adjusted for continuity Erbs diffuse fraction model has discontinuities at transition points Aug 14, 2023
@kandersolar kandersolar added this to the v0.10.2 milestone Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants