New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Functions to consider making private #1756
Comments
Only |
Unless I'm mistaken, the calculation in |
I've gone back and forth on this and ultimately I guess it's ok. It seems unnecessarily hostile to users that actually went to the effort to read source code, and we want more of those users rather than antagonizing the few that we have. I've used some of these functions in my own code, but I'm not the typical user and I can update it if I need to. And I'd like to see spa moved to its own package, but who wants to support that? Which is the point, isn't it? |
My thinking is that (with the possible exception of I do think the non-SPA functions listed above should probably be private though. |
The SPA-related changes in #1769 are now reverted. Now it only changes the other functions listed above. I'd rather improve the SPA docs in a separate PR. |
On closer inspection, I realized |
I noticed we have several functions that don't have pages in our API reference, but are also not private (name doesn't start with
_
):solar_position
,transit_sunrise_sunset
,earthsun_distance
, andcalculate_deltat
I propose we make all these functions private (add a leading underscore to their names). I doubt they get any meaningful amount of use, so I wouldn't bother with a deprecation for any of them.
The text was updated successfully, but these errors were encountered: