Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breakdown_factor type in singlediode.bishop88 docs #1820

Closed
reepoi opened this issue Aug 1, 2023 · 0 comments · Fixed by #1821
Closed

breakdown_factor type in singlediode.bishop88 docs #1820

reepoi opened this issue Aug 1, 2023 · 0 comments · Fixed by #1821
Milestone

Comments

@reepoi
Copy link
Contributor

reepoi commented Aug 1, 2023

Describe the bug
The docs of the singlediode.bishop88* functions say that breakdown_factor can be numeric, but these functions crash when breakdown_factor is an array of length two or more. This is caused by the if-statement here.

Expected behavior
The functions can be modified to support the numeric type for breakdown_factor, or the docs can be updated to say that breakdown_factor must be a float.

Versions:

  • pvlib.__version__: 0.10.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants